Skip to content

Collect recursively and filter GPU tests using jax_test_gpu tag #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 21, 2024
Merged

Collect recursively and filter GPU tests using jax_test_gpu tag #1091

merged 5 commits into from
Oct 21, 2024

Conversation

@andportnoy
Copy link
Contributor

@andportnoy andportnoy commented Oct 9, 2024

No description provided.

@andportnoy
Copy link
Contributor Author

andportnoy commented Oct 9, 2024

Needs jax-ml/jax#24218.

@olupton olupton closed this Oct 10, 2024
@olupton olupton reopened this Oct 10, 2024
yhtang
yhtang reviewed Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@yhtang yhtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like JAX unit tests resulted in 20k+ errors and my browser just spent the last 10 mins loading the error log...

@andportnoy
Copy link
Contributor Author

andportnoy commented Oct 10, 2024

Yeah this confuses me because the errors that I see are all of the form

RuntimeError: Backend 'tpu' failed to initialize: INTERNAL: Failed to open libtpu.so: libtpu.so: cannot open shared object file: No such file or directory. Available backends are ['cpu', 'cuda']

in tests like //tests:blocked_sampler_test_tpu. But one would think these tests shouldn't be collected when filtering with --test_tag_filters=jax_test_gpu"...

@andportnoy
Copy link
Contributor Author

andportnoy commented Oct 10, 2024 •
edited
Loading

The full command is

bazel test \
  --//jax:build_jaxlib=false \
  //tests/... \
  --test_tag_filters=jax_test_gpu \
  --@local_config_cuda//:enable_cuda \
  --cache_test_results=no \
  --test_timeout=600 \
  --test_tag_filters=-multiaccelerator \
  --test_env=JAX_SKIP_SLOW_TESTS=1 \
  --test_env=JAX_ACCELERATOR_COUNT=8 \
  --test_env=XLA_PYTHON_CLIENT_ALLOCATOR=platform \
  --test_env=XLA_PYTHON_CLIENT_PREALLOCATE=false \
  --test_output=errors \
  --java_runtime_version=remotejdk_11 \
  --run_under /opt/jax/build/parallel_accelerator_execute.sh \
  --local_test_jobs=64 \
  --test_env=JAX_TESTS_PER_ACCELERATOR=8 \
  --test_env=JAX_EXCLUDE_TEST_TARGETS=PmapTest.testSizeOverflow

I wonder if --test_tag_filters cannot be repeated and so --test_tag_filters=-multiaccelerator overrides --test_tag_filters=jax_test_gpu?

Nope, --test_tag_filters cannot be repeated: bazelbuild/bazel#7322.

@andportnoy andportnoy force-pushed the aportnoy/use-jax_test_gpu branch from d10cf20 to ceff277 Compare October 11, 2024 16:44
yhtang
yhtang previously approved these changes Oct 14, 2024
View reviewed changes
@andportnoy
Copy link
Contributor Author

andportnoy commented Oct 15, 2024

jax-ml/jax#24322 fixes //tests/mosaic:flash_attention_gpu on V100/A100.

@andportnoy andportnoy requested a review from yhtang October 18, 2024 16:59
olupton
olupton approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@olupton olupton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
//tests/mosaic:flash_attention_gpu is failing, but I don't think that should block merging this

@olupton olupton merged commit cfc3f74 into main Oct 21, 2024
139 of 143 checks passed
@olupton olupton deleted the aportnoy/use-jax_test_gpu branch October 21, 2024 11:43
@andportnoy
Copy link
Contributor Author

andportnoy commented Oct 22, 2024

//tests/mosaic:flash_attention_gpu is failing

Fixed in jax-ml/jax#24467.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olupton olupton olupton approved these changes

@DwarKapex DwarKapex Awaiting requested review from DwarKapex

@yhtang yhtang Awaiting requested review from yhtang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andportnoy @yhtang @olupton